[IMP] altinkaya_account: replace KRFRK-based currency diff with FIFO aggregate calculation#281
Open
umyigit wants to merge 4 commits intoaltinkaya-opensource:16.0from
Open
[IMP] altinkaya_account: replace KRFRK-based currency diff with FIFO aggregate calculation#281umyigit wants to merge 4 commits intoaltinkaya-opensource:16.0from
umyigit wants to merge 4 commits intoaltinkaya-opensource:16.0from
Conversation
Contributor
umyigit
commented
Mar 13, 2026
umyigit
commented
- Replace the old KRFRK-sum based currency difference calculation with a FIFO aggregate method that matches payments to invoices chronologically, producing results consistent with manual accounting (ekstre) calculations
- Fix tax distribution bug where USD and TL amounts were mixed, causing invoice totals to not match the calculated currency difference
- Map old VAT rates (18%, 8%) to current rates (20%, 10%) so KFARK invoices don't fail on historical invoices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.